Fix notebooks instances recreating for scopes and CMEK #17232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add labels to runtime update test * fix notebooks instances recreating for scopes and CMEK * Update resource_notebooks_runtime_test.go.erb * Update Instance.yaml * Apply suggestions from code review regarding kms keys Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> * Update notebook_instance_full.tf.erb * remove scope diff suppress * add vars in test * Enable parallelstore API (hashicorp#9919) * Add Cloud Deploy Delivery Pipeline (hashicorp#9888) Co-authored-by: Cameron Thornton <camthornton@google.com> * Promote support for replica mv in resource_bigquery_table to GA (hashicorp#9909) * Ignore .github folder when using Copywrite tool (hashicorp#9920) * networksecurity/AddressGroup: remove unused custom code (hashicorp#9829) Co-authored-by: Luca Prete <lucaprete@google.com> * Add fine grained resource for instance group membership (hashicorp#9891) * Add fine-grained resource * Add InstanceGroupMembership resource * add acceptance tests for the resource * Add message to the resource * Fix trailing spaces * Fix trailing spaces * Add zone to test * Add zone to test * Review fixes - change fields labels, update descriptions and indentation * Undo mistake change * Remove flatten from the encoder * Remove "Region" prefix in the test files and decoder, as it could be replaces with the existingfill_to_relative_path custom_flatten * Add beta support for confidentialInstanceType (hashicorp#9847) * Modify posture deployment field descriptions (hashicorp#9900) * modify posture dpeloyment field description * Update mmv1/products/securityposture/PostureDeployment.yaml Co-authored-by: Nick Elliot <nickelliot@google.com> * Update mmv1/products/securityposture/PostureDeployment.yaml Co-authored-by: Nick Elliot <nickelliot@google.com> --------- Co-authored-by: Sneha Prasad <snehaprasad@google.com> Co-authored-by: Nick Elliot <nickelliot@google.com> * fixing version == beta to unless version = ga (hashicorp#9922) * Fix branching for beta (hashicorp#9928) * fixing version == beta to unless version = ga * fixing beta branching * fix notebooks instances recreating for scopes and CMEK * diff suppress for kms key * remove scope diff suppress * add vars in test * change kms key to use existing one in tests * add kms key diff suppress * add acctest. to BootstrapKMSKeyInLocation * add vars in test * change kms key to use existing one in tests * add vars in test * change kms key to use existing one in tests * fix notebooks instances recreating for scopes and CMEK * fix merge conflicts * add labels to runtime update test * fix notebooks instances recreating for scopes and CMEK * Update resource_notebooks_runtime_test.go.erb * Update Instance.yaml * Apply suggestions from code review regarding kms keys Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> * Update notebook_instance_full.tf.erb * remove scope diff suppress * add vars in test * fix notebooks instances recreating for scopes and CMEK * diff suppress for kms key * remove scope diff suppress * add vars in test * change kms key to use existing one in tests * add kms key diff suppress * add acctest. to BootstrapKMSKeyInLocation * add vars in test * change kms key to use existing one in tests * add vars in test * change kms key to use existing one in tests * fix notebooks instances recreating for scopes and CMEK * fix merge conflicts * retrigger checks --------- Co-authored-by: Sarah French <15078782+SarahFrench@users.noreply.github.com> Co-authored-by: Shogo Watanabe <1286807+nownabe@users.noreply.github.com> Co-authored-by: Cameron Thornton <camthornton@google.com> Co-authored-by: wj-chen <wjchen@google.com> Co-authored-by: Luca Prete <preteluca@gmail.com> Co-authored-by: Luca Prete <lucaprete@google.com> Co-authored-by: Filip 'Cherit' Szóstak <filipszostak@google.com> Co-authored-by: Dionna Amalie Glaze <drdeeglaze@gmail.com> Co-authored-by: Sneha Prasad <32434989+snpd25@users.noreply.github.com> Co-authored-by: Sneha Prasad <snehaprasad@google.com> Co-authored-by: Nick Elliot <nickelliot@google.com> Co-authored-by: unnatinadupalli <156947936+unnatinadupalli@users.noreply.github.com> [upstream:24092252cd739017ede0b2af2b398927e17f6d8a] Signed-off-by: Modular Magician <magic-modules@google.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
service_account_scopes#16587Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9915