Fix notebooks instances recreating for scopes and CMEK

[bcreddy-gcp]

• google_notebooks_instance seems to always force recreation when CMEK key encryption is set. hashicorp/terraform-provider-google#9164
• google_notebooks_instance resources recreated on every terraform apply without any configuration changes due to service_account_scopes hashicorp/terraform-provider-google#16587
• google_notebooks_instance state with kms_key do not detect drift hashicorp/terraform-provider-google#15274

Release Note Template for Downstream PRs (will be copied)

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 75 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 4 files changed, 75 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 1 file changed, 32 insertions(+))

[modular-magician]

Tests analytics

Total tests: 22
Passed tests 20
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• notebooks

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNotebooksRuntime_update|TestAccNotebooksInstance_notebookInstanceFullExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNotebooksRuntime_update[Error message] [Debug log]
TestAccNotebooksInstance_notebookInstanceFullExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 75 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 4 files changed, 75 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 1 file changed, 32 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 72 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 72 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 1 file changed, 32 insertions(+))

[modular-magician]

Tests analytics

Total tests: 22
Passed tests 21
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• notebooks

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNotebooksInstance_notebookInstanceFullExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNotebooksInstance_notebookInstanceFullExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[SarahFrench]

The recent error with the acceptance tests are due to this code being generated with empty strings as values for name - the solution is updating the variables used when templating out the acceptance test, e.g.:

    vars:
      instance_name: 'notebooks-instance'
+      key_name: 'my-key'
+      keyring_name: 'my-keyring'

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 72 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 72 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 1 file changed, 32 insertions(+))

[modular-magician]

Tests analytics

Total tests: 22
Passed tests 21
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• notebooks

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNotebooksInstance_notebookInstanceFullExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccNotebooksInstance_notebookInstanceFullExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[SarahFrench]

Some refactoring suggestions and a question about the issue with scopes.

Also, the latest test failure is due to a diff:

              ~ kms_key                = "projects/ci-test-project-188019/locations/global/keyRings/tf-test-tftest-shared-keyring-12bfr7fw32x/cryptoKeys/tf-test-tftest-shared-key-12bfr7fw32x/cryptoKeyVersions/1" -> "projects/ci-test-project-188019/locations/global/keyRings/tf-test-tftest-shared-keyring-12bfr7fw32x/cryptoKeys/tf-test-tftest-shared-key-12bfr7fw32x" # forces replacement

The POST request to create the resource doesn't include cryptoKeyVersions/1 in the value, but the response from the API includes cryptoKeyVersions/1. This could be addressed by a diff suppress function also.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 53 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 3 files changed, 53 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 1 file changed, 32 insertions(+))

[modular-magician]

Tests analytics

Total tests: 0
Passed tests 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• notebooks

$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR}}$
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 3 files changed, 64 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 64 insertions(+), 6 deletions(-))
TF Conversion: Diff ( 1 file changed, 40 insertions(+))

[modular-magician]

Tests analytics

Total tests: 22
Passed tests 21
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages

• notebooks

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccNotebooksInstance_notebookInstanceFullExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccNotebooksInstance_notebookInstanceFullExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[bcreddy-gcp]

Hey @SarahFrench, could you please take a look at the PR.

[SarahFrench]

Sorry for the delay - I was juggling a few tasks and wanted to do a quick manual test of this PR before approving