Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google_cloudfunctions_function does not support setting dead letter queue on the topic #9748

Open
jonesaaronj opened this issue Aug 9, 2021 · 2 comments

Comments

@jonesaaronj
Copy link

jonesaaronj commented Aug 9, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment. If the issue is assigned to the "modular-magician" user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If the issue is assigned to a user, that user is claiming responsibility for the issue. If the issue is assigned to "hashibot", a community member has claimed the issue already.

Description

When creating a google cloud function with a pub/sub event trigger there is no way to set the dead letter queue of the created subscription

New or Affected Resource(s)

  • google_cloudfunctions_function

Potential Terraform Configuration

# Propose what you think the configuration to take advantage of this feature should look like.
# We may not use it verbatim, but it's helpful in understanding your intent.
resource "google_cloudfunctions_function" "my_cloud_function" {
   ...
  event_trigger {
    event_type = "google.pubsub.topic.publish"
    resource = "projects/GCP_PROJECT/topics/my_topic"
    failure_policy {
      retry = false
    }
    dead_letter_policy {
      dead_letter_topic = "projects/GCP_PROJECT/topics/my_dead_letter_topic"
      max_delivery_attempts = 5
    }
  }
}

References

  • b/274818382
@rileykarson rileykarson added this to the Goals milestone Aug 9, 2021
@lemoo5sg
Copy link

lemoo5sg commented Aug 18, 2022

Hello,
We have the same need here.
Thanks in advance for your help.
(adding a comment as the issue seems stuck in a realm ;) )

@roaks3
Copy link
Collaborator

roaks3 commented Oct 6, 2022

Unfortunately this option does not seem to be possible using our API at the moment (v1 or v2). Please correct me if there are API or gcloud docs that describe this configuration being applied directly to the Cloud Function, but until then, this will need to be handled upstream before we can add the fields to this Terraform resource.

@roaks3 roaks3 added the upstream label Oct 6, 2022
modular-magician added a commit to modular-magician/terraform-provider-google that referenced this issue Jan 4, 2024
…hashicorp#9748)

Co-authored-by: Luca Prete <lucaprete@google.com>
[upstream:ce85734ca809d9b8769df5456854ea8f6b680468]

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this issue Jan 4, 2024
…16900)

[upstream:ce85734ca809d9b8769df5456854ea8f6b680468]

Signed-off-by: Modular Magician <magic-modules@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants