Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illustrate how a Pubsub Subscription ttl would be specified as indefinite #14175

Closed
wants to merge 1 commit into from

Conversation

ethankent
Copy link

Because of the way a human might skim this doc, some are likely to wind up with the wrong default value. Imagine that someone has gone straight to the ttl section and missed the reference to a 31 day default in the expiration_policy section. They would likely then create an empty expiration_policy block and get a validation error. After removing that block altogether the validation error would disappear, but they would be left with a 31 day expiration rather than the indefinite one they had desired.

@github-actions
Copy link

github-actions bot commented Apr 1, 2023

** WARNING **: This repository is generated by https://github.com/GoogleCloudPlatform/magic-modules. Any changes made directly to this repository will likely be overwritten. If you have further questions, please feel free to ping your reviewer or, internal employees, reach out to one of the engineers. Thank you!

@SarahFrench
Copy link
Member

Hi @ethankent - could you please open a new PR in the upstream GoogleCloudPlatform/magic-modules repo for this change? I believe you'd need to update this line to cause the documentation to be updated like in this PR. Thanks!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants