Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document inverse of k8s default behaviour #814

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

rsalmond
Copy link
Contributor

@rsalmond rsalmond commented Apr 7, 2020

Description

Document reversal of k8s default values for automount_service_account_token field.

Acceptance tests

  • Have you added an acceptance test for the functionality being added?
  • Have you run the acceptance tests on this branch? (If so, please include the test log in a gist)

References

Addresses #263. Hopefully saves folks some debugging time in the future.

@hashicorp-cla
Copy link

hashicorp-cla commented Jun 11, 2020

CLA assistant check
All committers have signed the CLA.

@aareet aareet merged commit 61f2431 into hashicorp:master Jul 1, 2020
@ghost
Copy link

ghost commented Aug 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Aug 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants