Fix mount_options in nomad_volume
#188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgfa29
force-pushed
the
fix-nomad-volume-mount-options
branch
from
231adb3
to
13c3ccd
Compare
cgbaker
previously approved these changes
Jan 15, 2021
Co-authored-by: Chris Baker <1675087+cgbaker@users.noreply.github.com>
|
@cgbaker can I get a ✅? 😄 |
|
that's so weird, i thought i did.... has github changed the order of the combo box or something? |
This was referenced Jan 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
nomad_volumeresource hadmount_optionsas a map with complex types, which Terraform can't process properly. The Nomad API also redactsmount_optionsfrom its response since it may contain sensitive values.This PR changes the field type to a list with only 1 item to allow passing the sub-fields from the config file. It also doesn't try to read back
mount_optionsfrom the API since it will always benil.Since the schema was modified, a migration function was necessary.
Fixes #182