Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vault and consul token to job resource #261

Merged
merged 3 commits into from
Mar 2, 2022

Conversation

anth0d
Copy link
Contributor

@anth0d anth0d commented Feb 15, 2022

There is an implicit cyclic dependency between providers when you try to use dynamic (i.e., generated by another provider) vault_token and consul_token in your Nomad provider configuration. This change introduces the ability to provide vault_token and consul_token as part of the nomad_job resource, so that dynamic token values can be provided by vault and consul providers respectively without hitting the provider dependency issue.

Let me know how I can ensure the registry docs are also up to date with this change, and let me know if anything else is needed! Thanks!

Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anth0d, and sorry for the delay in getting this reviewed.

I pushed a commit adding a note to the docs about storing these sensitive values in the state.

@lgfa29 lgfa29 merged commit 978b91d into hashicorp:main Mar 2, 2022
lgfa29 added a commit that referenced this pull request Mar 2, 2022
lgfa29 added a commit that referenced this pull request Mar 2, 2022
elprans pushed a commit to edgedb/terraform-provider-nomad that referenced this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants