Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set memory_oversubscription_enabled in resourceSchedulerConfigurationRead #259

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

Mongey
Copy link
Contributor

@Mongey Mongey commented Jan 21, 2022

Closes #258
If there's a more elegant way to write the test, lmk

Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks @Mongey! Tests looks great 👍

And apologies for the delay in getting this reviewed 😅

@lgfa29 lgfa29 merged commit 6db9328 into hashicorp:main Mar 2, 2022
lgfa29 added a commit that referenced this pull request Mar 2, 2022
lgfa29 added a commit that referenced this pull request Mar 2, 2022
elprans pushed a commit to edgedb/terraform-provider-nomad that referenced this pull request Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nomad_scheduler_config.memory_oversubscription_enabled never updated
2 participants