Set fields when importing csi volume registrations #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgfa29
added a commit
that referenced
this pull request
Dec 15, 2023
lgfa29
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Thank you for the PR @gastrodon!
Your analysis was spot on, but the fix was actually a little simpler. The missing attributes were actually missing from resourceCSIVolumeRead, which is what the passthrough importer uses.
I pushed a commit with this approach and also added a changelog entry.
Thanks again for the contribution!
|
Oops...I forgot I will push a commit to fix it tomorrow. |
Create resourceCSIVolumeRegistrationImport, and set some of the fields that plan otherwises proposes require replacing
Some volume attributes were not being set on read, resulting in incorrect import results.
The `resourceCSIVolumeRead` method was shared between `nomad_csi_volume` and `nomad_csi_volume_registration`, but the `external_id` attribute is only available for `nomad_csi_volume_registration`, so the method needs to be split.
lgfa29
force-pushed
the
nomad-csi-import-fields
branch
from
6f54c11
to
fde2d0d
Compare
This was referenced Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create
resourceCSIVolumeRegistrationImport, and set some of the fields that terraform otherwise wants to re-create the registration overRelated to #390