Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix TestResourceVariable_namespaceChange #441

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Mar 12, 2024

Establish implicit dependency between the variable and the new namespace so they are destroyed in the right order.

Closes #440

Establish implicit dependency between the variable and the new namespace
so they are destroyed in the right order.
Copy link
Member

@gulducat gulducat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do TF provider stuff so rarely, weird to see hcl variable syntax as a golang string argument, but after a bit of mental acrobatics through Sprintf()s, LGTM!

@lgfa29
Copy link
Contributor Author

lgfa29 commented Mar 12, 2024

Yeah, Terraform tests run Terraform configs, so using resource reference is how you would normally write this to make sure the DAG is properly defined.

@lgfa29 lgfa29 merged commit a57251a into main Mar 12, 2024
3 checks passed
@lgfa29 lgfa29 deleted the b-fix-var-ns-test branch March 12, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: TestResourceVariable_namespaceChange failing
2 participants