Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Use isValidString not nil check for private_key #113

Merged
merged 1 commit into from
Dec 13, 2019
Merged

BUGFIX: Use isValidString not nil check for private_key #113

merged 1 commit into from
Dec 13, 2019

Conversation

veverkap
Copy link
Contributor

@veverkap veverkap commented Dec 13, 2019 •
edited
Loading

Fixes issue with using oauth_client without private_key

This issue was fixed in upstream go-tfe#96

hashicorp/go-tfe@8b656f1#diff-46a4389c1970fe153de179797df5681d

thrashr888
thrashr888 approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@thrashr888 thrashr888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm +1

@veverkap veverkap merged commit 6a00ea7 into master Dec 13, 2019
@veverkap veverkap deleted the veverkap/fix_oauth_client branch December 13, 2019 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrashr888 thrashr888 thrashr888 approved these changes

@svanharmelen svanharmelen Awaiting requested review from svanharmelen

@alisdair alisdair Awaiting requested review from alisdair

@sudomateo sudomateo Awaiting requested review from sudomateo

Assignees
No one assigned
Labels
dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veverkap @thrashr888