Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description to workspace variables #121

Merged
merged 6 commits into from
Feb 11, 2020

Conversation

stasquatch
Copy link

@stasquatch stasquatch commented Feb 5, 2020

Description

Workspace variables (terraform and env) now support descriptions. These descriptions are complete separate from descriptions defined in an ingressed config, but appear in the Terraform Cloud UI where Variables are configured.

Testing plan

Create a variable with a description like:

resource "tfe_variable" "pet_name_length" {
    key = "pet_name_length"
    value = "5"
    description = "length of pet name in words"
    category = "terraform"
    workspace_id = tfe_workspace.workspace_name.id
}

Local test results 02/10/2020

Screen Shot 2020-02-06 at 6 09 42 PM

@stasquatch stasquatch marked this pull request as ready for review February 6, 2020 22:38
@stasquatch stasquatch force-pushed the acespacecase/workspace-var-desc branch from 483405a to 9587a4b Compare February 6, 2020 22:42
@stasquatch stasquatch force-pushed the acespacecase/workspace-var-desc branch from 9587a4b to ef9b49f Compare February 10, 2020 15:13
@ghost ghost added size/S and removed size/XL labels Feb 10, 2020
Copy link
Contributor

@lafentres lafentres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating isn't working (adding description to variable that doesn't have one, changing description, etc). i think it needs to be added to the resourceTFEVariableUpdate method.

i also ran into some errors running make build because go fmt needs to be run on tfe/resource_tfe_variable.go.

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@lafentres lafentres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉🎉
noodle-dog-technologist-intensifies

@stasquatch stasquatch merged commit 0e0208b into master Feb 11, 2020
@stasquatch stasquatch deleted the acespacecase/workspace-var-desc branch February 11, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants