Allow setting hostname via TFE_HOSTNAME ENV variable #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
svanharmelen
suggested changes
Mar 25, 2019
|
Hi @svanharmelen! Just ran into this while trying to get the acceptance tests passing to test #76. Can you share a bit more about what changes need to be made beyond @radeksimko's tweak so I can shepherd this in? |
|
As discussed offline, I think we can merge this now. But probably only after adding a |
|
This is implemented and merged in PR #78 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses one part of #31 (just the hostname part, not credentials).
There doesn't seem to be any way to set the hostname dynamically now, as opposed to credentials.