Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TFE_HOSTNAME and TFE_TOKEN environment variables #78

Merged
merged 4 commits into from Jun 5, 2019
Merged

Add support for TFE_HOSTNAME and TFE_TOKEN environment variables #78

merged 4 commits into from Jun 5, 2019

Conversation

alisdair
Copy link
Member

@alisdair alisdair commented Jun 4, 2019

Follow-up to @radeksimko's #65 as a separate PR from my fork because I don't have push access.

@svanharmelen, is this what you intended?

@ghost ghost added the size/XS label Jun 4, 2019
@alisdair
Copy link
Member Author

alisdair commented Jun 4, 2019

I got the acceptance tests to pass locally on this branch and updated the README with some extended documentation on how to run them.

@svanharmelen
Copy link
Contributor

@ghost ghost added documentation size/S and removed size/XS labels Jun 5, 2019
@alisdair
Copy link
Member Author

alisdair commented Jun 5, 2019

Looks good, but maybe we should update this as well: https://github.com/terraform-providers/terraform-provider-tfe/blob/master/website/docs/index.html.markdown

Agreed, thanks for the pointer. Done in b84a576.

@svanharmelen svanharmelen merged commit 97c55bc into hashicorp:master Jun 5, 2019
@alisdair alisdair deleted the tfe-hostname-token-environment-variables branch June 5, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants