-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce no-code modules in registry modules #673
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelhrocha
changed the title
create and update no-code module
🚧 [WIP] 🚧 create and update no-code module
Oct 26, 2022
miguelhrocha
changed the title
🚧 [WIP] 🚧 create and update no-code module
Introduce no-code modules in registry modules
Nov 15, 2022
sebasslash
requested changes
Nov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're almost there 😄 👍 -- Some blocking feedback below ⬇️
sebasslash
approved these changes
Nov 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've smoked tested ✔️ and behaves as expected. Requested changes have also been addressed 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-up of hashicorp/go-tfe#562, which adds the
no_code
module attribute to the registry module resource. This will enable practitioners to bootstrap modules in their TFE instance set up for no-code workspace provisioning.This change is dependent on the
go-tfe
PR mentioned before, once that merge this PR will be ready for review.External links
Output from acceptance tests
Screenshots