[#TF-722] Allow safe and force delete through the tfe provider #675
Conversation
emlanctot
changed the title
emlanctot
force-pushed
the
el/tf-722
branch
2 times, most recently
from
0c53b4f
to
321be76
Compare
emlanctot
force-pushed
the
el/tf-722
branch
8 times, most recently
from
e658690
to
c137aa9
Compare
emlanctot
force-pushed
the
el/tf-722
branch
4 times, most recently
from
2cbd1cf
to
7dbdcc9
Compare
There was a problem hiding this comment.
I really appreciate the unit testing you added to delete because it can be difficult to set up the prerequisites for a conflict
I feel like the behavior of force_delete is unique enough to warrant mentioning in the error message because it's a meta argument. What do you think?
This is a great contribution, thanks!
|
This is great, if we can cut a release soon, that would be super awesome! |
| func errWorkspaceSafeDeleteWithPermission(workspaceID string, err error) error { | ||
| if err != nil { | ||
| if strings.HasPrefix(err.Error(), "conflict") { | ||
| return fmt.Errorf("Error deleting workspace %s: %w\nTo delete this workspace without destroying the managed resources, add force_delete = true to the resource config.", workspaceID, err) | ||
| } | ||
| } | ||
| return nil | ||
| } |
There was a problem hiding this comment.
the logic here seems wrong; if there's an error, and it's not a conflict, this function should still return the err value. i saw this behavior today when i destroyed a terraform cloud workspace, and the workspace wasn't actually deleted but the apply succeeded and the resource was removed from state.
Description
Adds the
force_deleteattribute to a workspace provider resource.External links
Output from acceptance tests
Please run applicable acceptance tests locally and include the output here. See TESTS.md to learn how to run acceptance tests.
If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.