-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BETA] CRUD support for no-code registry modules #836
Conversation
363ad44
to
df0a48a
Compare
df0a48a
to
7ee2933
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Comments below.
organization = tfe_organization.test-organization.name | ||
namespace = "terraform-aws-modules" | ||
module_provider = "aws" | ||
name = "vpc" | ||
registry_name = "public" | ||
no_code = true | ||
} | ||
|
||
resource "tfe_nocode_module" "foobar" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doc is for the tfe_registry_module
, the "tfe_nocode_module"
resource example should go into it's own doc, is there a reason for adding it here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creating an entirely new no-code registry module is a combination of the no-code module and registry module resource.
a78bd38
to
7c52ad1
Compare
7c52ad1
to
0c0b3c1
Compare
0c0b3c1
to
d91329f
Compare
8af47ce
to
f89760a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! I couldn't break it during smoke testing.
6cb2f6d
to
e81723b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, it looks like you've addressed the review feedback, and Brandon already manually tested the feature and thought it worked well.
The one bit of feedback I see remaining is whether you wanted to use the built-in schema deprecation feature rather than hand-rolling one with GetOk(). But I'm OK either way! It also looks like you'll need to resolve a go.mod conflict, so ping me when you're ready for re-approval and I'll fast-track it.
Thanks @nfagerlund . Looking forward to the next release |
Docs reference
I'll get a PR to fix the docs :) Edit: Looks like y'all are already on this :D |
Description
This adds support for managing a no-code registry modules. It introduces a new resource called tfe_nocode_module which can be attached to a tfe_registry_module resource, to make it a no-code module. The user can also define variable options for the no-code module, adding a finite number of values allowed for the variable.
Testing plan
Note: Because the organization needs to have permissions to the featureflag, and the organization will be created during the test, you'll have to test this against a local atlas instance where the flag is defaulted to true for everyone.
my-org
) and ensure they have access to the new no-code API (you can do that in launchdarkly)Basic no-code module
With variable options
External links
Output from acceptance tests
Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.
If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.