[BETA] CRUD support for no-code registry modules

[dsa0x]

Description

This adds support for managing a no-code registry modules. It introduces a new resource called tfe_nocode_module which can be attached to a tfe_registry_module resource, to make it a no-code module. The user can also define variable options for the no-code module, adding a finite number of values allowed for the variable.

Testing plan

Note: Because the organization needs to have permissions to the featureflag, and the organization will be created during the test, you'll have to test this against a local atlas instance where the flag is defaulted to true for everyone.

• Create a User in TFC
• Create an Organization (e.g my-org) and ensure they have access to the new no-code API (you can do that in launchdarkly)
• Generate an API token for your user in TFC
• Point the dev environment to your user and TFC instance. e.g

// tfe/resource_tfe_no_code_module_test.go
func init() {
	os.Setenv("TF_ACC", "1")
	os.Setenv("ENABLE_BETA", "1")
	os.Setenv("TFE_ADDRESS", "https://tfcdev-foobar.eu.ngrok.io")
	os.Setenv("TFE_HOSTNAME", "tfcdev-foobar.eu.ngrok.io")
	os.Setenv("TFE_TOKEN", "your-token")
}

• Manually test with various configurations similar to:

  • Basic no-code module

    resource "tfe_organization" "foobar" {
    name  = "my-org"
    email = "admin@company.com"
    }
    
    resource "tfe_registry_module" "foobar" {
        organization    = tfe_organization.foobar.id
        module_provider = "my_provider"
        name            = "test_module"
    }
    
    resource "tfe_nocode_module" "foobar" {
        organization = tfe_organization.foobar.id
        registry_module = tfe_registry_module.foobar.id
    }

  • With variable options

    resource "tfe_organization" "foobar" {
    name  = "my-org"
    email = "admin@company.com"
    }
    
    resource "tfe_registry_module" "foobar" {
        organization    = tfe_organization.foobar.id
        module_provider = "my_provider"
        name            = "test_module"
    }
    
    resource "tfe_nocode_module" "foobar" {
        organization = tfe_organization.foobar.id
        registry_module = tfe_registry_module.foobar.id
    
        variable_options {
            name    = "ami"
            type    = "string"
            options = [ "ami-0", "ami-1", "ami-2" ]
        }
    
        variable_options {
            name    = "region"
            type    = "string"
            options = ["us-east-1","us-west-2"]
        }
    }

• Ensure new tests pass

External links

• Related go-tfe PR

Output from acceptance tests

Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.

If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.

$ go test -timeout 30m -run ^TestAccTFENoCodeModule_ github.com/hashicorp/terraform-provider-tfe/tfe -v
=== RUN   TestAccTFENoCodeModule_basic
--- PASS: TestAccTFENoCodeModule_basic (8.64s)
=== RUN   TestAccTFENoCodeModule_with_variable_options
--- PASS: TestAccTFENoCodeModule_with_variable_options (8.09s)
=== RUN   TestAccTFENoCodeModule_update
--- PASS: TestAccTFENoCodeModule_update (12.67s)
=== RUN   TestAccTFENoCodeModule_update_variable_options
--- PASS: TestAccTFENoCodeModule_update_variable_options (12.78s)
=== RUN   TestAccTFENoCodeModule_delete
--- PASS: TestAccTFENoCodeModule_delete (12.63s)
=== RUN   TestAccTFENoCodeModule_import
--- PASS: TestAccTFENoCodeModule_import (9.76s)
PASS
ok      github.com/hashicorp/terraform-provider-tfe/tfe 65.336s

...

[Uk1288]

Looking good! Comments below.

[Uk1288]

this doc is for the tfe_registry_module, the "tfe_nocode_module" resource example should go into it's own doc, is there a reason for adding it here too?

[dsa0x]

Creating an entirely new no-code registry module is a combination of the no-code module and registry module resource.

[brandonc]

Very nice! I couldn't break it during smoke testing.

[nfagerlund]

OK, it looks like you've addressed the review feedback, and Brandon already manually tested the feature and thought it worked well.

The one bit of feedback I see remaining is whether you wanted to use the built-in schema deprecation feature rather than hand-rolling one with GetOk(). But I'm OK either way! It also looks like you'll need to resolve a go.mod conflict, so ping me when you're ready for re-approval and I'll fast-track it.

addressed review

[dsa0x]

Thanks @nfagerlund . Looking forward to the next release

[lucymhdavies]

Docs reference module, but the actual argument is registry_module

$ terraform apply
╷
│ Error: Missing required argument
│
│   on registry.tf line 82, in resource "tfe_no_code_module" "foobar":
│   82: resource "tfe_no_code_module" "foobar" {
│
│ The argument "registry_module" is required, but no definition was found.
╵
╷
│ Error: Unsupported argument
│
│   on registry.tf line 85, in resource "tfe_no_code_module" "foobar":
│   85:   module = tfe_registry_module.private-nocode-modules[each.key].id
│
│ An argument named "module" is not expected here.

I'll get a PR to fix the docs :)

Edit: Looks like y'all are already on this :D
#858