-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support to configure execution mode #92
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good 👍 It probably only need some (updated) tests and maybe we should think for a minute about the name remote_execution
.
While I very much agree that this name is more descriptive then just operation
, it's about the only place were we would have a different name in the TF provider then what is used in the API. Not a problem, but something to make a conscious decision about.
Renamed to operations Alphabetized new item in the schema Initial pass at adding to tests
Thank you again for the feedback. I pushed some changes to implement the changes. I'm okay with renaming this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 also looks good to me!
Fixes #87 |
3068a13
to
7d09326
Compare
Attempting to add the ability to manage execution mode via the SDK. Looking for some feedback and also help with adding this to tests.
Requires hashicorp/go-tfe#84 to be merged first.