Add support for case_sensitive_names in the vault_ldap_auth_backend #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch check for case_sensitive_names to GetOkExists, this should fix the issue of a `false` won't being `ok` in case insensitivity is on.
|
|
|
@vinay-gopalan @benashz I see you did some work in the repo recently, could you guys review this and merge it? |
benashz
approved these changes
Feb 10, 2022
benashz
reviewed
Feb 10, 2022
|
Any recurring test failures in CI will be addressed a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #894
This PR is an extension of @stokkie90 fix that was proposed in #895
I've updated the docs and tests, plus added switched to GetOkExists when checking
case_sensitive_namesas recommended by @catsby.I've also set the default to
falseto be consistent with Vault's behaviour.