Add support for case_sensitive_names in the vault_ldap_auth_backend #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
catsby
requested changes
Nov 6, 2020
| @@ -204,6 +209,10 @@ func ldapAuthBackendUpdate(d *schema.ResourceData, meta interface{}) error { | |||
| data["bindpass"] = v.(string) | |||
| } | |||
|
|
|||
| if v, ok := d.GetOk("case_sensitive_names"); ok { | |||
There was a problem hiding this comment.
I think this needs to be d.GetOkExists like starttls above, otherwise a value of false wont return ok == true, so we could be in a situation where we can enable this but never disable it. A default value seems in order as well, if possible
There was a problem hiding this comment.
I just created this mr with an idea this might solve it. I probably need some help with it. And how to test it. But will get back to this on Monday.
There was a problem hiding this comment.
Suggested change
| if v, ok := d.GetOk("case_sensitive_names"); ok { | |
| if v, ok := d.GetOkExists("case_sensitive_names"); ok { |
|
Closing with #1176 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #894