-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vault_namespace
data source
#1768
Conversation
Add data source for fetching information of specified or the current namespace.
}, | ||
}) | ||
|
||
/* TODO: Enable when #1766 merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this can be enabled now that #2033 is merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmatilai Thanks for the contribution and I apologize for the delay in the review. Overall the changes look reasonable.
I am getting the following build error:
$ make dev
==> Checking that code complies with gofmt requirements...
go build -o terraform-provider-vault
# github.com/hashicorp/terraform-provider-vault/vault
vault/data_source_namespace.go:21:16: undefined: ReadContextWrapper
vault/data_source_namespace.go:70:37: undefined: SysNamespaceRoot
make: *** [dev] Error 1
@fairclothjm Thanks for the feedback and attention! I didn't want to use more time on keeping the PRs up-to-date before getting any signal that they could be accepted. I have a bit busy week again, but will definitely try to rebase and revisit these soon. 🙂 |
@tmatilai FYI, I opened a PR which will supersede this PR. |
@fairclothjm Thank you so much! Sorry, I just haven't found the time and energy to clean these up. So many things going on... 😅 |
Add
vault_namespace
data source for fetching information of specified or the current namespace.Closes #1748
Relates #1766
Relates #1756
Output from acceptance testing
Community Note