Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add namespace data source #2208

Merged
merged 8 commits into from Mar 25, 2024
Merged

add namespace data source #2208

merged 8 commits into from Mar 25, 2024

Conversation

fairclothjm
Copy link
Contributor

@fairclothjm fairclothjm commented Mar 25, 2024 •
edited

Description

Piggy backs on the work from #1768

Closes #1768
Closes #995
Relates #1768

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

@fairclothjm fairclothjm changed the title Fairclothjm/namespace data source add namespace data source Mar 25, 2024
@fairclothjm fairclothjm added this to the 4.2.0 milestone Mar 25, 2024
@fairclothjm fairclothjm marked this pull request as draft March 25, 2024 18:22
@fairclothjm fairclothjm marked this pull request as ready for review March 25, 2024 18:33
vinay-gopalan
vinay-gopalan approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Had a couple suggested changes on docs, but should be good otherwise

vault/data_source_namespace.go Outdated Show resolved Hide resolved
website/docs/d/namespace.html.md Outdated Show resolved Hide resolved
website/docs/d/namespace.html.md Outdated Show resolved Hide resolved
website/docs/d/namespace.html.md Outdated Show resolved Hide resolved
website/docs/d/namespace.html.md Outdated Show resolved Hide resolved
vault/data_source_namespace.go Outdated Show resolved Hide resolved
@fairclothjm fairclothjm force-pushed the fairclothjm/namespace_data_source branch from 750e82f to bd75a40 Compare March 25, 2024 19:55
@fairclothjm fairclothjm merged commit e73b010 into main Mar 25, 2024
12 checks passed
@fairclothjm fairclothjm deleted the fairclothjm/namespace_data_source branch March 25, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

Assignees
No one assigned
Labels
documentation size/XL
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

How to check if Vault namespace already exist - getting "* namespace "mynamespace/" already exists"
3 participants
@fairclothjm @vinay-gopalan @tmatilai