Merged the virtual machine configuration schema between the both the resource and datasource #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irtual_machine resource into its data source, and modified the suppression functions in the data structure to use the ovf_deploy attribute conditionally.
…tual_machine" data source.
… some of the newly added attributes.
2 tasks
|
Apparently this is a bad rebase. Will fix once done submitting other PRs. |
|
Okay. Now for TravisCI to tell me how my tests look... |
…ne disk subresource file.
|
There we go. |
bill-rich
approved these changes
Aug 14, 2020
|
Awesome. Thank you for merging it! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This consolidates some of the common attributes such as the number of cpus, sizes, etc. that are shared between both the "vsphere_virtual_machine" resource and data source. This allows one to make a nearly exact 1:1 copy of a "vsphere_virtual_machine" data source without having to hardcode anything as described in all of the public articles and blog posts on the subject.
Some of the attributes for the data source were added to the tests, and the documentation was updated to reference the additional attributes.
Acceptance tests
References
This closes issue #1155, is related to a closed issue #285, and supercedes PR #1148.