Skip to content
This repository has been archived by the owner on Jul 5, 2023. It is now read-only.

Update how we set the environment to production, for segment tracking #263

Merged
merged 2 commits into from
Apr 27, 2018

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Apr 27, 2018

Default to development, which should always use the dev key from middleman helpers. Any value for DEPLOY_ENV will have that affect too, but thought it good to be explicit. Only a value of production will result in the production key.

This fixes an issue we have right now, where the development key is being used and data is being sent and registered as Development traffic and not Production traffic.

@catsby catsby requested a review from jescalan April 27, 2018 20:19
@catsby catsby merged commit 917741c into master Apr 27, 2018
@paultyng paultyng deleted the env-makefile branch September 12, 2018 13:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants