Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Optional" fields not supported at the provider level. #12736

Closed
paddycarver opened this issue Mar 15, 2017 · 5 comments · Fixed by #12822
Closed

"Optional" fields not supported at the provider level. #12736

paddycarver opened this issue Mar 15, 2017 · 5 comments · Fixed by #12822
Assignees

Comments

@paddycarver
Copy link
Contributor

When a provider's field is marked as removed, I'd expect Terraform to know not to prompt users for input on it, especially if the file is marked as optional. But in #12729, it appears that users are being prompted for input on a removed, optional field.

@mrmiyagi
Copy link
Contributor

yep, can't manage any google cloud resources!

@jbardin
Copy link
Member

jbardin commented Mar 16, 2017

@paddyforan, I think I see the difference here. All other uses of Removed are in resources, this is the only one that is at a provider level.

Turns out that that schema.Provider doesn't support Optional right now.

@jbardin jbardin changed the title Users still prompted for input on provider fields marked as removed. "Optional" fields not supported at the provider level. Mar 16, 2017
@jbardin jbardin self-assigned this Mar 16, 2017
@paddycarver
Copy link
Contributor Author

So is Removed not supported at the provider level? If not, is there a technical or UX reason it can't be? I guess the better question is: do we consider Removed not preventing Terraform from prompting for input a bug, or do we just consider Optional not preventing Terraform from prompting for input a bug? (Or both, I suppose?)

@jbardin
Copy link
Member

jbardin commented Mar 17, 2017

No, Removed technically is working just fine.

Optional is not working, so it will always prompt, or if there was a default, it would fail to validate.

@ghost
Copy link

ghost commented Apr 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants