Add name_prefix to RDS resources

[joshuaspence]

Adds name_prefix (or, in some cases, identifier_prefix) support to all AWS RDS resources.

[joshuaspence]

> make test TEST='./config' TESTARGS='-run=TestValidateDb\(OptionGroupName\|OptionGroupNamePrefix\|SubnetGroupName\|SubnetGroupNamePrefix\)'
==> Checking that code complies with gofmt requirements...
==> Checking AWS provider for unchecked errors...
==> NOTE: at this time we only look for uncheck errors in the AWS package
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/31 16:16:29 Generated command/internal_plugin_list.go
go test -i ./config || exit 1
echo ./config | \
    xargs -t -n4 go test -run=TestValidateDb\(OptionGroupName\|OptionGroupNamePrefix\|SubnetGroupName\|SubnetGroupNamePrefix\) -timeout=60s -parallel=4
go test -run=TestValidateDb(OptionGroupName|OptionGroupNamePrefix|SubnetGroupName|SubnetGroupNamePrefix) -timeout=60s -parallel=4 ./config 
ok      github.com/hashicorp/terraform/config   0.032s [no tests to run]

> make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWS\(DBClusterParameterGroup\|DBInstance\|DBOptionGroup\|DBParameterGroup\|DBSubnetGroup\|RDSCluster\|RDSClusterInstance\)_\(defaultDecription\|generatedName\|namePrefix\)'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/31 16:17:22 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWS\(DBClusterParameterGroup\|DBInstance\|DBOptionGroup\|DBParameterGroup\|DBSubnetGroup\|RDSCluster\|RDSClusterInstance\)_\(defaultDecription\|generatedName\|namePrefix\) -timeout 120m
=== RUN   TestAccAWSDBInstance_namePrefix
--- PASS: TestAccAWSDBInstance_namePrefix (461.98s)
=== RUN   TestAccAWSDBInstance_generatedName
--- PASS: TestAccAWSDBInstance_generatedName (462.22s)
=== RUN   TestAccAWSDBOptionGroup_namePrefix
--- PASS: TestAccAWSDBOptionGroup_namePrefix (34.51s)
=== RUN   TestAccAWSDBOptionGroup_generatedName
--- PASS: TestAccAWSDBOptionGroup_generatedName (35.94s)
=== RUN   TestAccAWSDBParameterGroup_namePrefix
--- PASS: TestAccAWSDBParameterGroup_namePrefix (40.15s)
=== RUN   TestAccAWSDBParameterGroup_generatedName
--- PASS: TestAccAWSDBParameterGroup_generatedName (38.30s)
=== RUN   TestAccAWSDBSubnetGroup_namePrefix
--- PASS: TestAccAWSDBSubnetGroup_namePrefix (64.90s)
=== RUN   TestAccAWSDBSubnetGroup_generatedName
--- PASS: TestAccAWSDBSubnetGroup_generatedName (71.29s)
=== RUN   TestAccAWSRDSClusterInstance_namePrefix
--- PASS: TestAccAWSRDSClusterInstance_namePrefix (800.34s)
=== RUN   TestAccAWSRDSClusterInstance_generatedName
--- PASS: TestAccAWSRDSClusterInstance_generatedName (736.64s)
=== RUN   TestAccAWSDBClusterParameterGroup_namePrefix
--- PASS: TestAccAWSDBClusterParameterGroup_namePrefix (36.97s)
=== RUN   TestAccAWSDBClusterParameterGroup_generatedName
--- PASS: TestAccAWSDBClusterParameterGroup_generatedName (37.08s)
=== RUN   TestAccAWSRDSCluster_namePrefix
--- PASS: TestAccAWSRDSCluster_namePrefix (176.22s)
=== RUN   TestAccAWSRDSCluster_generatedName
--- PASS: TestAccAWSRDSCluster_generatedName (195.03s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    3191.598s

[joshuaspence]

Whoops, I realized that I ran the tests incorrectly. Will fix.

[joshuaspence]

> make test TEST='./builtin/providers/aws' TESTARGS='-run=TestValidateDb\(OptionGroupName\|OptionGroupNamePrefix\|SubnetGroupName\|SubnetGroupNamePrefix\)'
==> Checking that code complies with gofmt requirements...
==> Checking AWS provider for unchecked errors...
==> NOTE: at this time we only look for uncheck errors in the AWS package
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/31 22:09:08 Generated command/internal_plugin_list.go
go test -i ./builtin/providers/aws || exit 1
echo ./builtin/providers/aws | \
	xargs -t -n4 go test -run=TestValidateDb\(OptionGroupName\|OptionGroupNamePrefix\|SubnetGroupName\|SubnetGroupNamePrefix\) -timeout=60s -parallel=4
go test -run=TestValidateDb(OptionGroupName|OptionGroupNamePrefix|SubnetGroupName|SubnetGroupNamePrefix) -timeout=60s -parallel=4 ./builtin/providers/aws 
ok  	github.com/hashicorp/terraform/builtin/providers/aws	0.039s

[stack72]

LGTM! Thanks for the work here @joshuaspence :)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.