Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[provider/aws] check that we actually have NodeGroupMembers #13488

Conversation

netjunki
Copy link
Contributor

@netjunki netjunki commented Apr 9, 2017

This fixes the crash I reported in #13487 but I don't quite understand why (other than the fact that the array obviously was empty but we try to access element 0 of it... but terraform plan does complete successfully after this change. Unclear if this is leaving the system in a weird state though.

Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Worst case scenario as I understand it would be empty node group information, which should get pick up on the next plan/refresh

@catsby
Copy link
Contributor

catsby commented Jun 5, 2017

Thanks!

@catsby catsby closed this Jun 5, 2017
@catsby catsby reopened this Jun 5, 2017
@catsby catsby merged commit ef4e89c into hashicorp:master Jun 5, 2017
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants