Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/google: fix panic in GKE provisioning with addons #13954

Merged
merged 1 commit into from
Apr 26, 2017

Conversation

danawillow
Copy link
Contributor

If any element in addons_config is set, the data structure will be returned fully expanded. Check that subelements aren't empty before attempting to access their contents.

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@radeksimko radeksimko merged commit 6ff114a into hashicorp:master Apr 26, 2017
@radeksimko
Copy link
Member

@danawillow sorry for breaching the etiquette here a little and merging this for you, but I thought it would be good to get this in prior to the next release which we're going to cut very soon since it's fixing a crash. 😄

@danawillow
Copy link
Contributor Author

No worries! Thanks @radeksimko :)

@ghost
Copy link

ghost commented Apr 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants