Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Allow updating tuples in WAF ByteMatchSet + no tuples #14071

Merged
merged 2 commits into from
May 19, 2017

Conversation

radeksimko
Copy link
Member

This is to fix a bug very similar to #10403 and #11959

TL;DR We were not deleting any tuples except when deleting the whole ByteMatchSet.

While fixing IPSet I noticed all the other WAF resources are affected too, so this is second PR fixing another resource - more will follow.

Test plan

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSWafByteMatchSet_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/28 11:49:01 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSWafByteMatchSet_ -timeout 120m
=== RUN   TestAccAWSWafByteMatchSet_basic
--- PASS: TestAccAWSWafByteMatchSet_basic (22.73s)
=== RUN   TestAccAWSWafByteMatchSet_changeNameForceNew
--- PASS: TestAccAWSWafByteMatchSet_changeNameForceNew (44.36s)
=== RUN   TestAccAWSWafByteMatchSet_changeTuples
--- PASS: TestAccAWSWafByteMatchSet_changeTuples (40.43s)
=== RUN   TestAccAWSWafByteMatchSet_noTuples
--- PASS: TestAccAWSWafByteMatchSet_noTuples (21.91s)
=== RUN   TestAccAWSWafByteMatchSet_disappears
--- PASS: TestAccAWSWafByteMatchSet_disappears (19.47s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	148.933s

cc @yusukegoto

Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@radeksimko radeksimko merged commit afe45b6 into master May 19, 2017
@radeksimko radeksimko deleted the b-aws-waf-byte-match-set branch May 19, 2017 07:14
@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants