Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make google resource storage bucket importable #14047 #14455

Merged
merged 1 commit into from
May 15, 2017

Conversation

emilymye
Copy link
Contributor

Also:

  • Add read to create
  • Set more fields in read

@stack72
Copy link
Contributor

stack72 commented May 15, 2017

LGTM! Thanks for this :)

% make testacc TEST=./builtin/providers/google TESTARGS='-run=TestAccStorageBucket'                ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/15 19:36:01 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccStorageBucket -timeout 120m
=== RUN   TestAccStorageBucketUpdate
--- PASS: TestAccStorageBucketUpdate (13.06s)
=== RUN   TestAccStorageBucketImport
--- PASS: TestAccStorageBucketImport (5.22s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/google	18.309s

@ghost
Copy link

ghost commented Apr 12, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants