Validate provisioner connection blocks #19707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And provide the connection config for validation
apparentlymart
approved these changes
Dec 19, 2018
terraform/eval_apply.go
Outdated
| // "on failure continue" setting only applies to failures of the | ||
| // provisioner itself, not to invalid configuration. | ||
| return diags.Err() | ||
| // start with an empty connInto |
There's a required field now, so evaluating an empty block will always fail.
Add host where required in the test configs, and fix the mock to check for a null connection.
jbardin
force-pushed
the
jbardin/connection
branch
from
ec81df8
to
0b59f9c
Compare
This was referenced Dec 19, 2018
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch errors in provisioners connection blocks during Validate rather than Apply.
Make
hosta required field, to better alert users that the old automatic connection mechanism is no longer used.