Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.11] backend/s3: Switch from github.com/terraform-providers/terraform-provider-aws to github.com/hashicorp/aws-sdk-go-base #20659

Merged
merged 1 commit into from
Mar 13, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Mar 12, 2019

Closes #20338
Closes #19992
Reference: #20374

This pull request is provided to simplify Terraform Provider migrations to Go Modules with v0.11.

Backports the S3 backend code from master to v0.11 relating to the AWS Go SDK, which removes the circular dependency with the Terraform AWS Provider and includes the addition of retry logic to the backend to prevent temporary networking or AWS service issues from failing unnecessarily.

Updated via code change then:

go mod tidy
go mod vendor

Output from acceptance testing:

--- PASS: TestBackend_impl (0.00s)
--- PASS: TestBackendConfig (0.39s)
--- PASS: TestBackendConfig_invalidKey (0.00s)
--- PASS: TestBackend (2.64s)
--- PASS: TestBackendLocked (9.81s)
--- PASS: TestBackendExtraPaths (3.08s)
--- PASS: TestBackendPrefixInWorkspace (1.61s)
--- PASS: TestKeyEnv (9.74s)
--- PASS: TestRemoteClient_impl (0.00s)
--- PASS: TestRemoteClient (1.68s)
--- PASS: TestRemoteClientLocks (12.21s)
--- PASS: TestForceUnlock (12.59s)
--- PASS: TestRemoteClient_clientMD5 (9.02s)
--- PASS: TestRemoteClient_stateChecksum (9.76s)

…ider-aws to github.com/hashicorp/aws-sdk-go-base

References:

* #20374
* #20338
* #19992

Backports the S3 backend code from master to v0.11 relating to the AWS Go SDK, which removes the circular dependency with the Terraform AWS Provider and adds retry logic to the backend to prevent temporary networking or AWS service issues from failing unnecessarily.

Updated via code change then:

```
go mod tidy
go mod vendor
```
@bflad bflad added this to the Terraform 0.11 milestone Mar 13, 2019
@bflad bflad removed the proposal label Mar 13, 2019
@bflad bflad merged commit 102c78c into v0.11 Mar 13, 2019
@bflad bflad deleted the td-v0.11-aws-sdk-go-base-backport branch March 13, 2019 16:50
bflad added a commit that referenced this pull request Mar 13, 2019
apparentlymart pushed a commit that referenced this pull request May 7, 2019
@ghost
Copy link

ghost commented Aug 13, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants