Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure modules are expanded during import #25208

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Jun 10, 2020

In order to import into a module, we have to make sure that module has
registered the expansion data.

Fixes #25192

In order to import into a module, we have to make sure that module has
registered the expansion data.
@jbardin jbardin requested a review from a team June 10, 2020 21:04
@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #25208 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
terraform/graph_builder_import.go 93.93% <100.00%> (+0.83%) ⬆️
terraform/node_resource_plan.go 91.80% <0.00%> (-1.64%) ⬇️
states/statefile/version4.go 57.87% <0.00%> (-0.29%) ⬇️
backend/remote/backend_common.go 55.25% <0.00%> (+0.67%) ⬆️
terraform/transform_import_state.go 93.70% <0.00%> (+1.57%) ⬆️

@jbardin jbardin merged commit 39cf911 into master Jun 12, 2020
@jbardin jbardin deleted the jbardin/expand-import branch June 12, 2020 16:45
@ghost
Copy link

ghost commented Jul 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jul 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"panic: no expansion registered" during import (modules not expanded)
2 participants