Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of New login success output for TFC/E into v0.15 #28487

Merged
merged 3 commits into from
Apr 22, 2021

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #28479 to be assessed for backporting due to the inclusion of the label 0.15-backport.

The below text is copied from the body of the original PR.


When logging in to Terraform Cloud or Terraform Enterprise, this changes the success output to be a bit more customized for the platform. For Terraform Cloud, fetch a dynamic welcome banner that intentionally fails open and defaults to a hardcoded message if it's not available for any reason.

Additionally, after some research to ensure that adding a code for 256 color terminals shouldn't be a problem, I've added a Terraform purple color code to the default list of colorstring codes.

Screenshots

Logging in to Terraform Cloud:

image

Logging in to Terraform Cloud (a failure case with trace logging enabled):

image

Logging in to Terraform Enterprise:

image

@teamterraform teamterraform force-pushed the backport/motd-for-tfc/globally-helping-kiwi branch from ec56266 to af5cbf8 Compare April 22, 2021 14:14
@codecov
Copy link

codecov bot commented Apr 22, 2021

Codecov Report

Merging #28487 (af5cbf8) into v0.15 (4036905) will decrease coverage by 0.04%.
The diff coverage is 58.20%.

Impacted Files Coverage Δ
command/login.go 45.57% <55.55%> (-4.68%) ⬇️
command/meta.go 69.56% <100.00%> (+0.40%) ⬆️

@chrisarcand chrisarcand merged commit 3d9e018 into v0.15 Apr 22, 2021
@chrisarcand chrisarcand deleted the backport/motd-for-tfc/globally-helping-kiwi branch April 22, 2021 14:22
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants