provider/aws: Migrate KeyPair to version 1

[catsby]

This PR upgrades resource_aws_key_pair to version 1.
It fixes #3455 , where reading a key with the file() included a trailing \n.

Copying and pasting that same public key (typically?) did not include this \n.
For example, swapping out the public_key method for the full string below should result in no change:

resource "aws_key_pair" "ssh_thing" {
  key_name = "tf-testing-file"
  public_key = "${file("~/.ssh/github_rsa.pub")}"
  #public_key = "ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEA4LBtwcFsQAYWw1cn== ctshryock"
}

Gives this plan:

+ aws_key_pair.ssh_thing
    fingerprint: "" => "<computed>"
    key_name:    "" => "tf-testing-file"
    public_key:  "" => "ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEA4LBtwcFsQAYWw1cn== ctshryock\n"

vs.

resource "aws_key_pair" "ssh_thing" {
  key_name = "tf-testing-file"
  #public_key = "${file("~/.ssh/github_rsa.pub")}"
  public_key = "ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEA4LBtwcFsQAYWw1cn== ctshryock"
}

and

+ aws_key_pair.ssh_thing
    fingerprint: "" => "<computed>"
    key_name:    "" => "tf-testing-file"
    public_key:  "" => "ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEA4LBtwcFsQAYWw1cn== ctshryock"

Swapping file() and the full string in-line should not produce a change, but on master it does.

This PR uses strings.TrimSpace() to trim off the trailing \n.

[catsby]

Worth noting too, that I checked both formats (with or without \n) to make sure the ability to SSH was maintained 👍

[phinze]

LGTM

[mitchellh]

Yeah, this seems right to me. ${file} is doing the right thing and reading the file byte for byte. SSH is just trimming the space off the end. Modifying the state storage is correct.

[duttadeep55]

Solved Solution 👍

resource "aws_key_pair" "deployer" {
key_name = "deployer-key"
public_key = "${file("ssh/insecure-deployer.pub")}"
}

This worked for me. :)

produce with terraform plan

• aws_key_pair.deployer
  fingerprint: ""
  key_name: "deployer-key"
  public_key: "ssh-rsa xxx insecure-deployer"

[duttadeep55]

But for the instance creation I am getting a long wait and ending

aws_instance.nat: Provisioning with 'remote-exec'...
aws_instance.nat (remote-exec): Connecting to remote host via SSH...
aws_instance.nat (remote-exec): Host: 52.213.15.2
aws_instance.nat (remote-exec): User: centos
aws_instance.nat (remote-exec): Password: false
aws_instance.nat (remote-exec): Private key: false
aws_instance.nat (remote-exec): SSH Agent: true
aws_instance.nat: Still creating... (30s elapsed)
aws_instance.nat: Still creating... (40s elapsed)
aws_instance.nat (remote-exec): Connecting to remote host via SSH...
aws_instance.nat (remote-exec): Host: 52.213.15.2
aws_instance.nat (remote-exec): User: centos
aws_instance.nat (remote-exec): Password: false
aws_instance.nat (remote-exec): Private key: false
aws_instance.nat (remote-exec): SSH Agent: true
aws_instance.nat: Still creating... (50s elapsed)
aws_instance.nat (remote-exec): Connecting to remote host via SSH...
aws_instance.nat (remote-exec): Host: 52.213.15.2
aws_instance.nat (remote-exec): User: centos
aws_instance.nat (remote-exec): Password: false
aws_instance.nat (remote-exec): Private key: false
aws_instance.nat (remote-exec): SSH Agent: true
aws_instance.nat: Still creating... (1m0s elapsed)
aws_instance.nat: Still creating... (1m10s elapsed)
^[[Baws_instance.nat (remote-exec): Connecting to remote host via SSH...
aws_instance.nat (remote-exec): Host: 52.213.15.2
aws_instance.nat (remote-exec): User: centos
aws_instance.nat (remote-exec): Password: false
aws_instance.nat (remote-exec): Private key: false
aws_instance.nat (remote-exec): SSH Agent: true

[duttadeep55]

Error applying plan:

1 error(s) occurred:

• ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.