provider/aws: aws_db_option_group #4401

stack72 · 2015-12-21T09:17:15Z

Scaffold the AWS DB Option Group resource

catsby · 2016-01-13T17:50:06Z

builtin/providers/aws/resource_aws_db_instance.go

@@ -362,8 +372,8 @@ func resourceAwsDbInstanceCreate(d *schema.ResourceData, meta interface{}) error
 			opts.TdeCredentialArn = aws.String(attr.(string))
 		}

-		if attr, ok := d.GetOk("storage_type"); ok {
-			opts.StorageType = aws.String(attr.(string))
+		if attr, ok := d.GetOk("option_group_name"); ok {


was it intentional to remove storage_type here?

You are correct - this is now fixed

Looks like this section now has two option_group_name clauses (L362 & L382).

catsby · 2016-01-13T17:56:21Z

Looks like a promising start! I have some comments/asks that I've made, let me know what you think

ocxo · 2016-01-28T16:10:58Z

This is looking good. Anything else needed to get this into the next release?

stack72 · 2016-01-28T16:16:34Z

@fromonesrc this just needs another check to make sure everyone is happy - I only finished up the enhancements in the past week. As soon as someone from the core team is happy, then we can merge :)

ocxo · 2016-01-28T16:17:11Z

Thanks for your work on this!

arthurschreiber · 2016-02-25T09:59:40Z

@phinze @catsby Can you guys take another look at this?

phinze · 2016-02-25T12:53:40Z

builtin/providers/aws/resource_aws_db_instance_test.go

+	parameter_group_name = "default.mysql5.6"
+	option_group_name = "${aws_db_option_group.bar.option_group_name}"
+}`, rand.New(rand.NewSource(time.Now().UnixNano())).Int())
+


Is this full config necessary for the option group test? Seems like we could trim it down to just what that test needs to assert its stuff.

We could probably use the new acctest.RandInt() here for ensuring the names are unique?

bigkraig · 2016-03-02T22:23:27Z

I got the last problem fixed. I needed to serialize the option_settings as part of resourceAwsDbOptionHash.

ocxo · 2016-03-08T16:43:28Z

@stack72 is this something you're working on or looking for help with?

arthurschreiber · 2016-03-08T16:54:28Z

Can we also have option_name -> name and option_settings -> settings? Resource properties being prefixed with the resource type is really weird and not DRY.

bigkraig · 2016-03-22T17:11:35Z

@stack72 I can update my pull request to your branch with the option_name & option_settings if that will help move things along

@phinze

Addressing @phinze's comments from hashicorp#4401

@phinze

Revert "Addressing @phinze's comments from hashicorp#4401"

stack72 · 2016-04-27T19:25:19Z

FYI, I am just working on getting the tests working here and then it will be ready to go

stack72 · 2016-04-27T20:45:34Z

ok this is now pending final review. I fixed up the comments @phinze gave (except the building of IAM - I have a follow up task for this once #5030 settles)

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSDBOptionGroup' 2>~/tf.log
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSDBOptionGroup -timeout 120m
=== RUN   TestAccAWSDBOptionGroup_basic
--- PASS: TestAccAWSDBOptionGroup_basic (16.05s)
=== RUN   TestAccAWSDBOptionGroup_sqlServerOptionsUpdate
--- PASS: TestAccAWSDBOptionGroup_sqlServerOptionsUpdate (27.36s)
=== RUN   TestAccAWSDBOptionGroup_multipleOptions
--- PASS: TestAccAWSDBOptionGroup_multipleOptions (16.46s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    59.886s

Change the AWS DB Instance to now include the DB Option Group param. Adds a test to prove that it works Add acceptance tests for the AWS DB Option Group work. This ensures that Options can be added and updated Documentation for the AWS DB Option resource

jen20 · 2016-05-08T23:34:12Z

Looks good now!

catsby · 2016-05-09T17:33:10Z

Looks like the test added to DB Instance was not updated, I patched it in #6558

stack72 · 2016-05-09T17:35:38Z

Sorry!

On Mon, May 9, 2016 at 6:33 PM, Clint notifications@github.com wrote:

Looks like the test added to DB Instance was not updated, I patched it in
#6558 #6558

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#4401 (comment)

ghost · 2020-04-26T01:52:53Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

stack72 force-pushed the aws-rds-option-groups branch 2 times, most recently from 716fd4d to 85613a4 Compare December 21, 2015 09:45

stack72 mentioned this pull request Dec 21, 2015

Add support for AWS RDS DB Options Group #4399

Closed

stack72 force-pushed the aws-rds-option-groups branch 3 times, most recently from edcf744 to 1ddf9de Compare December 22, 2015 15:10

stack72 changed the title ~~[WIP] provider/aws: aws_db_option_group~~ provider/aws: aws_db_option_group Dec 22, 2015

radeksimko added provider/aws enhancement labels Dec 23, 2015

catsby reviewed Jan 13, 2016
View reviewed changes

catsby added the waiting-response An issue/pull request is waiting for a response from the community label Jan 13, 2016

stack72 force-pushed the aws-rds-option-groups branch 4 times, most recently from 790a568 to 9c7d0dc Compare January 18, 2016 13:43

jen20 removed the waiting-response An issue/pull request is waiting for a response from the community label Jan 19, 2016

phinze reviewed Feb 25, 2016
View reviewed changes

stack72 added a commit to stack72/terraform that referenced this pull request Apr 11, 2016

Merge pull request #2 from bigkraig/aws-rds-option-groups

5d0d6db

Addressing @phinze's comments from hashicorp#4401

stack72 added a commit to stack72/terraform that referenced this pull request Apr 11, 2016

Revert "Addressing @phinze's comments from hashicorp#4401"

da4aaba

stack72 added a commit to stack72/terraform that referenced this pull request Apr 11, 2016

Merge pull request #3 from stack72/revert-2-aws-rds-option-groups

ac19a37

Revert "Addressing @phinze's comments from hashicorp#4401"

stack72 force-pushed the aws-rds-option-groups branch 4 times, most recently from ec19802 to 15befd0 Compare April 27, 2016 19:00

stack72 added the new-resource label Apr 27, 2016

stack72 force-pushed the aws-rds-option-groups branch from 15befd0 to 43cea49 Compare April 27, 2016 20:44

stack72 force-pushed the aws-rds-option-groups branch 3 times, most recently from 088c973 to 0844013 Compare April 27, 2016 22:58

stack72 force-pushed the aws-rds-option-groups branch from 0844013 to 88a1b7e Compare May 8, 2016 18:44

stack72 force-pushed the aws-rds-option-groups branch from 88a1b7e to 8dc123f Compare May 8, 2016 19:19

Update resource_aws_db_option_group.go

526aadd

jen20 merged commit 5366fab into hashicorp:master May 8, 2016

stack72 deleted the aws-rds-option-groups branch May 8, 2016 23:34

catsby mentioned this pull request May 9, 2016

provider/aws: Update paramter for DB Option Group #6558

Merged

ghost locked and limited conversation to collaborators Apr 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

provider/aws: aws_db_option_group #4401

provider/aws: aws_db_option_group #4401

stack72 commented Dec 21, 2015

catsby Jan 13, 2016

stack72 Jan 14, 2016

phinze Feb 25, 2016

catsby commented Jan 13, 2016

ocxo commented Jan 28, 2016

stack72 commented Jan 28, 2016

ocxo commented Jan 28, 2016

arthurschreiber commented Feb 25, 2016

phinze Feb 25, 2016

jen20 Apr 27, 2016

bigkraig commented Mar 2, 2016

ocxo commented Mar 8, 2016

arthurschreiber commented Mar 8, 2016

bigkraig commented Mar 22, 2016

stack72 commented Apr 27, 2016

stack72 commented Apr 27, 2016

jen20 commented May 8, 2016

catsby commented May 9, 2016

stack72 commented May 9, 2016

ghost commented Apr 26, 2020

provider/aws: aws_db_option_group #4401

provider/aws: aws_db_option_group #4401

Conversation

stack72 commented Dec 21, 2015

catsby Jan 13, 2016

Choose a reason for hiding this comment

stack72 Jan 14, 2016

Choose a reason for hiding this comment

phinze Feb 25, 2016

Choose a reason for hiding this comment

catsby commented Jan 13, 2016

ocxo commented Jan 28, 2016

stack72 commented Jan 28, 2016

ocxo commented Jan 28, 2016

arthurschreiber commented Feb 25, 2016

phinze Feb 25, 2016

Choose a reason for hiding this comment

jen20 Apr 27, 2016

Choose a reason for hiding this comment

bigkraig commented Mar 2, 2016

ocxo commented Mar 8, 2016

arthurschreiber commented Mar 8, 2016

bigkraig commented Mar 22, 2016

stack72 commented Apr 27, 2016

stack72 commented Apr 27, 2016

jen20 commented May 8, 2016

catsby commented May 9, 2016

stack72 commented May 9, 2016

ghost commented Apr 26, 2020