Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Add uuid() interpolate function. #5575

Merged
merged 2 commits into from
Mar 11, 2016
Merged

core: Add uuid() interpolate function. #5575

merged 2 commits into from
Mar 11, 2016

Conversation

phinze
Copy link
Contributor

@phinze phinze commented Mar 11, 2016

Utilize hashicorp's go-uuid library for proper random seeding setup.

@apparentlymart
Copy link
Contributor

Is this building on #3563 or is it a fresh implementation?

@phinze
Copy link
Contributor Author

phinze commented Mar 11, 2016

About to comment over there - I think we can rework #3563 to be caused something besides uuid() and keep this as a more "pure" uuid function.

@phinze
Copy link
Contributor Author

phinze commented Mar 11, 2016

(Working on the dep vendoring now too.)

@phinze phinze changed the title core: Add uuid() interpolate function. [WIP] core: Add uuid() interpolate function. Mar 11, 2016
Utilizes hashicorp's go-uuid library for proper random seeding setup.
@phinze phinze changed the title [WIP] core: Add uuid() interpolate function. core: Add uuid() interpolate function. Mar 11, 2016
@phinze phinze mentioned this pull request Mar 11, 2016
3 tasks
@jen20
Copy link
Contributor

jen20 commented Mar 11, 2016

This looks good to me. 👍

@gjohnson
Copy link

👍

phinze added a commit that referenced this pull request Mar 11, 2016
core: Add uuid() interpolate function.
@phinze phinze merged commit ece259f into master Mar 11, 2016
@phinze phinze deleted the phinze/uuid branch March 11, 2016 16:33
@gozer
Copy link

gozer commented Mar 14, 2016

That's great, but I was hoping something like this would become posible:

resource "aws_s3_bucket" "test" {
    lifecycle {
      ignore_changes = ["bucket"]
    }

    bucket = "some-prefix-${uuid()}"
    acl = "private"
}

However, the bucket creation itself initially fails, am I doing something obviously wrong here?

@phinze
Copy link
Contributor Author

phinze commented Mar 14, 2016

@gozer you're doing it right, that's a bug with ignore_changes that i'm actively working on fixing! stay tuned

@gozer
Copy link

gozer commented Mar 14, 2016

@phinze great, thanks for the feedback. Do you have an issue number for that ignore_change bug?

@phinze
Copy link
Contributor Author

phinze commented Mar 14, 2016

@gozer just opened a roll-up issue for my efforts 👉 #5627

@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants