[#4794] Don't Base64-encode EC2 userdata if it is already Base64 encoded #6140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user data may be Base64 encoded already - for example, if it has been generated by a template_cloudinit_config resource.
dougneal
changed the title
|
Looks good, thanks! Could I trouble you to throw some already encoded data into the config of the TestAccAWSInstance_vpc? You can reuse this user_data encoding. That will give us an acceptance test that verifies this works. Let me know! |
catsby
added
waiting-response
|
Hey @catsby, something like this? It doesn't decode to anything meaningful, but it passes as a valid Base64 encoding. |
dougneal
force-pushed
the
4794/ec2_userdata_dont_double_base64
branch
from
40ff572
to
f020ebb
Compare
dougneal
force-pushed
the
4794/ec2_userdata_dont_double_base64
branch
from
f020ebb
to
0181b6b
Compare
|
Yep! I'll to add the |
catsby
removed
the
waiting-response
chrislovecnm
pushed a commit
to chrislovecnm/terraform
that referenced
this pull request
Apr 16, 2016
…se64 encoded (hashicorp#6140) * Don't Base64-encode EC2 userdata if it is already Base64 encoded The user data may be Base64 encoded already - for example, if it has been generated by a template_cloudinit_config resource. * Add encoded user_data to aws_instance acceptance test
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user data may be Base64 encoded already - for example, if it has been generated by a template_cloudinit_config resource.
Partially resolves #4794