support aurora instance's parameter group and modifyinstance

[arcadiatea]

This change for #6841.

[catsby]

Hey @arcadiatea – am I correct that we can simply use the existing aws_db_parameter_group, correct?

[catsby]

This attribute doesn't seem to be set anywhere, what is it meant to record? The DBInstanceStatus, or status from StatusInfos.DBInstanceStatusInfo.N ?

• http://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_DBInstance.html

[catsby]

I have a question about the status attribute but I did test out this branch and it worked as expected 👍

Note to self:

fixes #5023 too

[arcadiatea]

Hey, @catsby
This change is to allow Aurora instance be able to use customized parameter group set by aws_db_parameter_group.
The current issues is Aurora instance always created with default db parameter group and not be able to detect the modify requirement.

[catsby]

@arcadiatea yep! I tried it out and it works as expected. I do have an question about the added status parameter; it's not being set, and it's not clear to me what value this should be. Do you recall?

[arcadiatea]

@catsby that status attribute is not be used for this modification , you are right.
I am working on another enhancement feature on aws_rds_cluster_instance (support security_group changes) and I can include the usage of status there.

status attribute be used in aws_db_instance for support debug information on resourceAwsDbInstanceStateRefreshFunc, and I plan to mimic the function in aws_rds_cluster_instance

[catsby]

Ok, thanks for clarifying! If you remove that attribute from this commit, I'll go ahead and merge this

[arcadiatea]

@catsby status attributes is removed. This change probably also fix #5710, #5436

[catsby]

Thanks! I'm going to merge this with an addition to the test file as well.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.