Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"aws_elb" "cross_zone_load_balancing" set default to true #6891

Closed
danbf opened this issue May 26, 2016 · 4 comments
Closed

"aws_elb" "cross_zone_load_balancing" set default to true #6891

danbf opened this issue May 26, 2016 · 4 comments

Comments

@danbf
Copy link

danbf commented May 26, 2016

Can we set Default,: true, in https://github.com/optimisticanshul/terraform/blob/830708a882c86fd157cb8395f1b884806e0462d1/builtin/providers/aws/resource_aws_elb.go#L45-L48 ?

This is the default now for all ELB's created via the AWS console.

Terraform Version

Terraform v0.6.15

Affected Resource(s)

Please list the resources as a list, for example:

  • aws_elb

Expected Behavior

elb should be created with cross_zone_load_balancing enabled

Actual Behavior

elb is created with cross_zone_load_balancing disabled

Steps to Reproduce

  1. terraform apply of the example in https://www.terraform.io/docs/providers/aws/r/elb.html without the cross_zone_load_balancing = true line
# Create a new load balancer
resource "aws_elb" "bar" {
  name = "foobar-terraform-elb"
  availability_zones = ["us-west-2a", "us-west-2b", "us-west-2c"]

  access_logs {
    bucket = "foo"
    bucket_prefix = "bar"
    interval = 60
  }

  listener {
    instance_port = 8000
    instance_protocol = "http"
    lb_port = 80
    lb_protocol = "http"
  }

  listener {
    instance_port = 8000
    instance_protocol = "http"
    lb_port = 443
    lb_protocol = "https"
    ssl_certificate_id = "arn:aws:iam::123456789012:server-certificate/certName"
  }

  health_check {
    healthy_threshold = 2
    unhealthy_threshold = 2
    timeout = 3
    target = "HTTP:8000/"
    interval = 30
  }

  instances = ["${aws_instance.foo.id}"]
  idle_timeout = 400
  connection_draining = true
  connection_draining_timeout = 400

  tags {
    Name = "foobar-terraform-elb"
  }
}
@stack72
Copy link
Contributor

stack72 commented Jun 2, 2016

Hi @danbf

just a FYI, we have just merged a PR that does exactly this. It will be released as part of TF 0.7 :)

Paul

@stack72 stack72 closed this as completed Jun 2, 2016
@danbf
Copy link
Author

danbf commented Jun 10, 2016

@stack72 awesome. thanks for getting this done.

@danbf
Copy link
Author

danbf commented Nov 18, 2016

giphy-1

@ghost
Copy link

ghost commented Apr 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants