Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Restore Defaults to SQS Queues #7818

Merged
merged 3 commits into from
Jul 26, 2016
Merged

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Jul 26, 2016

Fixes #7505 by removing computed and adding default values, to match with the SDK defaults.

I think this is somewhat new territory, as we typically just do nothing with the removal of an optional, computed value, but here we restore the defaults because they are documented. Without this, you couldn't remove a setting once you set it, you'd have to find the default yourself and manually set it.

@stack72
Copy link
Contributor

stack72 commented Jul 26, 2016

@catsby LGTM!

There was 1 small issue with a test:

=== RUN   TestAccAWSSQSQueue_importBasic
--- FAIL: TestAccAWSSQSQueue_importBasic (15.87s)
    testing.go:264: Step 1 error: Resource specified by ResourceName couldn't be found: aws_sqs_queue.queue-with-defaults

Fixed in 4e1d54a

@stack72 stack72 merged commit 348f6ba into master Jul 26, 2016
@stack72 stack72 deleted the b-aws-sqs-defaults branch July 26, 2016 21:00
@ghost
Copy link

ghost commented Apr 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_sqs_queue not restoring visibility_timeout_seconds to default value after removal of attribute
2 participants