provider/aws: Add resource for an ELB SSL negotiation policy

[bigkraig]

This is basically a dupe of #5637 but @fpmosley didn't have the bandwidth to rebase.

[stack72]

Fixes #2171 / Fixes #3176

[stack72]

Hey @bigkraig

Thanks so much for the rebase here - the test doesn't work I'm afraid :(

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSLBSSLNegotiationPolicy'
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/10 11:58:56 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSLBSSLNegotiationPolicy -timeout 120m
=== RUN   TestAccAWSLBSSLNegotiationPolicy_basic
--- FAIL: TestAccAWSLBSSLNegotiationPolicy_basic (12.81s)
    testing.go:264: Step 0 error: Error applying: 1 error(s) occurred:

        * aws_iam_server_certificate.test_cert: [WARN] Error uploading server certificate, error: MalformedCertificate: Certificate is no longer valid. The 'Not After' date restriction on the certificate has passed.
FAIL
exit status 1
FAIL    github.com/hashicorp/terraform/builtin/providers/aws    12.832s
make: *** [testacc] Error 1

Any chance you could have a look?

P.

[jamesdehart]

Seems it might be just bad test data.

[fpmosley]

@bigkraig @stack72 The Acceptance Test fails because it is using an expired certificate that was lifted from:
builtin/providers/aws/resource_aws_iam_server_certificate_test.go

The certs were fixed in this commit:
005d9a1

Just take the certs from there and it should work.

[bigkraig]

@stack72 I've updated the test data and it looks good

Kraigs-MacBook-Pro:terraform kamador$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSLBSSLNegotiationPolicy'
==> Checking that code complies with gofmt requirements...
/Users/kamador/gocode/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/10 13:30:32 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSLBSSLNegotiationPolicy -timeout 120m
=== RUN   TestAccAWSLBSSLNegotiationPolicy_basic
--- PASS: TestAccAWSLBSSLNegotiationPolicy_basic (27.99s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    28.009s

[fpmosley]

@bigkraig Looks like you were already on top of it fixing it. Great!

[stack72]

@bigkraig this looks good to me now :) Thanks so much! - just manually merged this!

[gokul-p]

This fix will be included in next release ? whats plan for next release ?

[stack72]

Hi @gokul-p

yes this will be included for 0.7.1 - there is no formal release date yet

Paul

[gokul-p]

thanks @stack72 - Please update me,once you have the date.

[41jules1967]

This seems to be in place but I can't tell if it's working.
The console screens don't make any reference to the new policy and imply the ELB is using the default policy.
Is it actually working?

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.