Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/google: Support Import of 'google_compute_http_health_check' #8121

Merged
merged 1 commit into from
Aug 11, 2016

Conversation

nwwebb
Copy link
Contributor

@nwwebb nwwebb commented Aug 10, 2016

make testacc TEST=./builtin/providers/google TESTARGS='-run=TestAccComputeHttpHealthCheck_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccComputeHttpHealthCheck_ -timeout 120m
=== RUN   TestAccComputeHttpHealthCheck_importBasic
--- PASS: TestAccComputeHttpHealthCheck_importBasic (26.32s)
=== RUN   TestAccComputeHttpHealthCheck_basic
--- PASS: TestAccComputeHttpHealthCheck_basic (26.29s)
=== RUN   TestAccComputeHttpHealthCheck_update
--- PASS: TestAccComputeHttpHealthCheck_update (51.75s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/google 
104.416s

@lwander

@@ -220,11 +224,14 @@ func resourceComputeHttpHealthCheckRead(d *schema.ResourceData, meta interface{}
d.Set("host", hchk.Host)
d.Set("request_path", hchk.RequestPath)
d.Set("check_interval_sec", hchk.CheckIntervalSec)
d.Set("health_threshold", hchk.HealthyThreshold)
d.Set("healthy_threshold", hchk.HealthyThreshold)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@lwander
Copy link
Contributor

lwander commented Aug 11, 2016

LGTM

@lwander lwander merged commit ad4ca17 into hashicorp:master Aug 11, 2016
@nwwebb nwwebb changed the title provider/google: Support Import of 'google_resource_http_health_check' provider/google: Support Import of 'google_compute_http_health_check' Aug 12, 2016
@ghost
Copy link

ghost commented Apr 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants