provider/aws: Add force_destroy option to aws_route53_zone

[radeksimko]

This option can be useful when there's something/someone outside of Terraform managing DNS records in a given zone. The naming convention/functionality follows aws_s3_bucket.

Acceptance tests

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSRoute53Zone'

TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSRoute53Zone -timeout 120m
=== RUN   TestAccAWSRoute53Zone_importBasic
--- PASS: TestAccAWSRoute53Zone_importBasic (50.48s)
=== RUN   TestAccAWSRoute53ZoneAssociation_basic
--- PASS: TestAccAWSRoute53ZoneAssociation_basic (113.97s)
=== RUN   TestAccAWSRoute53ZoneAssociation_region
--- PASS: TestAccAWSRoute53ZoneAssociation_region (129.97s)
=== RUN   TestAccAWSRoute53Zone_basic
--- PASS: TestAccAWSRoute53Zone_basic (52.34s)
=== RUN   TestAccAWSRoute53Zone_forceDestroy
--- PASS: TestAccAWSRoute53Zone_forceDestroy (439.65s)
=== RUN   TestAccAWSRoute53Zone_updateComment
--- PASS: TestAccAWSRoute53Zone_updateComment (64.82s)
=== RUN   TestAccAWSRoute53Zone_private_basic
--- PASS: TestAccAWSRoute53Zone_private_basic (79.72s)
=== RUN   TestAccAWSRoute53Zone_private_region
--- PASS: TestAccAWSRoute53Zone_private_region (80.06s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    1011.049s

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=AWSRoute53Record'

TF_ACC=1 go test ./builtin/providers/aws -v -run=AWSRoute53Record -timeout 120m
=== RUN   TestAWSRoute53RecordMigrateState
--- PASS: TestAWSRoute53RecordMigrateState (0.00s)
=== RUN   TestAWSRoute53RecordMigrateStateV1toV2
--- PASS: TestAWSRoute53RecordMigrateStateV1toV2 (0.00s)
=== RUN   TestAccAWSRoute53Record_basic
--- PASS: TestAccAWSRoute53Record_basic (167.03s)
=== RUN   TestAccAWSRoute53Record_basic_fqdn
--- PASS: TestAccAWSRoute53Record_basic_fqdn (203.35s)
=== RUN   TestAccAWSRoute53Record_txtSupport
--- PASS: TestAccAWSRoute53Record_txtSupport (165.12s)
=== RUN   TestAccAWSRoute53Record_spfSupport
--- PASS: TestAccAWSRoute53Record_spfSupport (152.43s)
=== RUN   TestAccAWSRoute53Record_generatesSuffix
--- PASS: TestAccAWSRoute53Record_generatesSuffix (119.94s)
=== RUN   TestAccAWSRoute53Record_wildcard
--- PASS: TestAccAWSRoute53Record_wildcard (152.19s)
=== RUN   TestAccAWSRoute53Record_failover
--- PASS: TestAccAWSRoute53Record_failover (95.93s)
=== RUN   TestAccAWSRoute53Record_weighted_basic
--- PASS: TestAccAWSRoute53Record_weighted_basic (105.52s)
=== RUN   TestAccAWSRoute53Record_alias
--- PASS: TestAccAWSRoute53Record_alias (108.35s)
=== RUN   TestAccAWSRoute53Record_s3_alias
--- PASS: TestAccAWSRoute53Record_s3_alias (110.39s)
=== RUN   TestAccAWSRoute53Record_weighted_alias
--- PASS: TestAccAWSRoute53Record_weighted_alias (204.49s)
=== RUN   TestAccAWSRoute53Record_geolocation_basic
--- PASS: TestAccAWSRoute53Record_geolocation_basic (106.39s)
=== RUN   TestAccAWSRoute53Record_latency_basic
--- PASS: TestAccAWSRoute53Record_latency_basic (99.64s)
=== RUN   TestAccAWSRoute53Record_TypeChange
--- PASS: TestAccAWSRoute53Record_TypeChange (155.27s)
=== RUN   TestAccAWSRoute53Record_empty
--- PASS: TestAccAWSRoute53Record_empty (101.77s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    2047.842s

[stack72]

Love that you remembered the Import test :)

[radeksimko]

Well, the reality is that it just showed up in a failed acceptance test. 😄

[mitchellh]

Makes sense and LGTM, thanks for the great tests too. Merge at your leisure.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.