Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: add aws_ssm_association resource #8376

Closed
wants to merge 2 commits into from
Closed

provider/aws: add aws_ssm_association resource #8376

wants to merge 2 commits into from

Conversation

liamjbennett
Copy link
Contributor

@liamjbennett liamjbennett commented Aug 22, 2016

Depends on #8282

Part of solution for: #4952

@liamjbennett liamjbennett changed the title [WIP] provider/aws: add aws_ssm_association resource provider/aws: add aws_ssm_association resource Aug 25, 2016
},
"parameters": &schema.Schema{
Type: schema.TypeMap,
Optional: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this isn't updatable, then it should be marked as ForceNew: true,

@stack72 stack72 added the waiting-response An issue/pull request is waiting for a response from the community label Aug 28, 2016
@stack72
Copy link
Contributor

stack72 commented Aug 28, 2016

Hey @liamjbennett

Thanks for the PR - lots of comments inlne

P.

@liamjbennett
Copy link
Contributor Author

➜  terraform git:(aws_ssm_association) ✗ AWS_REGION=eu-west-1 TF_LOG=TRACE TF_LOG_PATH=test_log.txt make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSSMAssociation_basic'
==> Checking that code complies with gofmt requirements...
/home/liam/development/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/09/02 08:56:04 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSSMAssociation_basic -timeout 120m
=== RUN   TestAccAWSSSMAssociation_basic
--- PASS: TestAccAWSSSMAssociation_basic (209.11s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    209.120s

@liamjbennett
Copy link
Contributor Author

@stack72 hopefully this now covers all your comments.

@stack72
Copy link
Contributor

stack72 commented Sep 2, 2016

Hi @liamjbennett

this LGTM now :) I made 1 change before merging manually - f9183da

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSSMAssociation_'                                                    2 ↵ ✹
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/09/02 16:56:09 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSSMAssociation_ -timeout 120m
=== RUN   TestAccAWSSSMAssociation_basic
--- PASS: TestAccAWSSSMAssociation_basic (136.23s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    136.246s

@stack72 stack72 closed this Sep 2, 2016
@ghost
Copy link

ghost commented Apr 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement provider/aws waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants