provider/aws: Refresh aws_autoscaling_policy from state on 404
#8430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #8386 When an Autoscaling Group Or an Autoscaling Group Policy has been deleted manually, terraform was throwing an error as follows: ``` * aws_autoscaling_policy.increase: Error retrieving scaling policies: ValidationError: Group sandbox-logs-logstash-wxhsckky3ndpzd7b3kmyontngy not found status code: 400, request id: 56a89814-6884-11e6-b3a8-d364cf04223b ``` We now refresh from state on a ValidationError - this is a common 4xx error according to AWS documentation http://docs.aws.amazon.com/AutoScaling/latest/APIReference/CommonErrors.html ``` %make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSAutoscalingPolicy_disappears' ==> Checking that code complies with gofmt requirements... /Users/stacko/Code/go/bin/stringer go generate $(go list ./... | grep -v /terraform/vendor/) TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSAutoscalingPolicy_disappears -timeout 120m === RUN TestAccAWSAutoscalingPolicy_disappears --- PASS: TestAccAWSAutoscalingPolicy_disappears (203.61s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 203.633s ```
| @@ -271,6 +272,13 @@ func getAwsAutoscalingPolicy(d *schema.ResourceData, meta interface{}) (*autosca | |||
| log.Printf("[DEBUG] AutoScaling Scaling Policy Describe Params: %#v", params) | |||
| resp, err := autoscalingconn.DescribePolicies(¶ms) | |||
| if err != nil { | |||
| //A ValidationError here can mean that either the Policy is missing OR the Autoscaling Group is missing | |||
| if ec2err, ok := err.(awserr.Error); ok && ec2err.Code() == "ValidationError" { | |||
| log.Printf("[WARNING] %s not found, refreshing from state", d.Id()) | |||
There was a problem hiding this comment.
should say "removing" from state?
|
Minor gripe on the log message wording otherwise LGTM. |
richardbowden
pushed a commit
to richardbowden/terraform
that referenced
this pull request
Aug 27, 2016
…hicorp#8430) * provider/aws: Refresh `aws_autoscaling_policy` from state on 404 Fixes hashicorp#8386 When an Autoscaling Group Or an Autoscaling Group Policy has been deleted manually, terraform was throwing an error as follows: ``` * aws_autoscaling_policy.increase: Error retrieving scaling policies: ValidationError: Group sandbox-logs-logstash-wxhsckky3ndpzd7b3kmyontngy not found status code: 400, request id: 56a89814-6884-11e6-b3a8-d364cf04223b ``` We now refresh from state on a ValidationError - this is a common 4xx error according to AWS documentation http://docs.aws.amazon.com/AutoScaling/latest/APIReference/CommonErrors.html ``` %make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSAutoscalingPolicy_disappears' ==> Checking that code complies with gofmt requirements... /Users/stacko/Code/go/bin/stringer go generate $(go list ./... | grep -v /terraform/vendor/) TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSAutoscalingPolicy_disappears -timeout 120m === RUN TestAccAWSAutoscalingPolicy_disappears --- PASS: TestAccAWSAutoscalingPolicy_disappears (203.61s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 203.633s ``` * Update resource_aws_autoscaling_policy.go
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8386
When an Autoscaling Group Or an Autoscaling Group Policy has been
deleted manually, terraform was throwing an error as follows:
We now refresh from state on a ValidationError - this is a common 4xx error according to AWS documentation http://docs.aws.amazon.com/AutoScaling/latest/APIReference/CommonErrors.html