core: add wildcard (match all) support to ignore_changes #8599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -83,6 +83,10 @@ include `create_before_destroy`. Referencing a resource that does not include | |||
| ~> **NOTE on ignore\_changes:** Ignored attribute names can be matched by their | |||
| name, not state ID. For example, if an `aws_route_table` has two routes defined | |||
| and the `ignore_changes` list contains "route", both routes will be ignored. | |||
| Additionally you can also use a single entry with a wildcard (e.g. `"*"`) | |||
| which will match all attribute names. Using a partial string together with a | |||
| wildcard (e.g. `"rout*"`) is **not** supported. | |||
There was a problem hiding this comment.
Can we add on a validation to this field to enforce that * is only a valid character when it appears alone?
There was a problem hiding this comment.
Yes, I guess it would be good to inform users to manage their expectations. So added a validation for this one.
|
LGTM! |
|
Thanks for the review @phinze! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One use case for supporting a wildcard feature like this, is for when you want to completely lock down a resource in an efficient way.
You can already protect it from being destroyed or recreated by using
prevent_destroy, but if you also want to prevent it from being altered in any way after it has been initially created, you'll have to manually make sure you have included all the possible attributes that can be used (so not only the ones you have initially configured, but all attributes).Of course it is much easier if in those cases you can just add a single entry with a
*to "lock" the resource for all changes.