-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/aws: Add JSON validation to the aws_kms_key resource. #8900
provider/aws: Add JSON validation to the aws_kms_key resource. #8900
Conversation
Part of work which began in #8028. |
Acceptance test is passing:
|
@@ -143,7 +144,8 @@ func resourceAwsKmsKeyRead(d *schema.ResourceData, meta interface{}) error { | |||
return err | |||
} | |||
|
|||
d.Set("policy", normalizeJson(*p.Policy)) | |||
policy, _ := normalizeJsonString(*p.Policy) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to check for any errors here?
7ff7ad2
to
b54aaf4
Compare
This commit adds support for new helper function which is used to normalise and validate JSON string. Signed-off-by: Krzysztof Wilczynski <krzysztof.wilczynski@linux.com>
b54aaf4
to
7d77048
Compare
Signed-off-by: Krzysztof Wilczynski <krzysztof.wilczynski@linux.com>
7d77048
to
8f68981
Compare
LGTM! Thanks for the work here :)
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This commit adds support for new helper function which is used to
normalise and validate JSON string.
Signed-off-by: Krzysztof Wilczynski krzysztof.wilczynski@linux.com