provider/aws: aws_ami: handle deletion of AMIs #9721
Conversation
Previously this resource (and, by extension, the aws_ami_copy and aws_ami_from_instance resources that share much of its implementation) was handling correctly the case where an AMI had been recently deregistered, and was thus still returned from the API, but not correctly dealing with the situation where the AMI has been removed altogether. Now we additionally handle the NotFound error returned by the API when we request a non-existent AMI, and remove the AMI from the state in the same way we do for deregistered AMIs.
|
His looks good - would the addition of a _disappears style test prove that this works? |
|
@stack72 It's not easy to test this in the usual way a I tested this myself here by creating a Terraform state with an intentionally-incorrect AMI id in it and running |
|
@apparentlymart makes sense :) In that case, LGTM! |
Previously this resource (and, by extension, the aws_ami_copy and aws_ami_from_instance resources that share much of its implementation) was handling correctly the case where an AMI had been recently deregistered, and was thus still returned from the API, but not correctly dealing with the situation where the AMI has been removed altogether. Now we additionally handle the NotFound error returned by the API when we request a non-existent AMI, and remove the AMI from the state in the same way we do for deregistered AMIs.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Previously this resource (and, by extension, the
aws_ami_copyandaws_ami_from_instanceresources that share much of its implementation) was handling correctly the case where an AMI had been recently deregistered, and was thus still returned from the API, but not correctly dealing with the situation where the AMI has been removed altogether.Now we additionally handle the
NotFounderror returned by the API when we request a non-existent AMI, and remove the AMI from the state in the same way we do for deregistered AMIs.(I'm sorry to say that I've been sitting on this one for a while and just
-targeting around the issues this was causing in my environment. 😞)