Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/openstack: Openstack Provider Updates #9725

Merged
merged 7 commits into from
Nov 1, 2016

Conversation

jtopjian
Copy link
Contributor

@jtopjian jtopjian commented Oct 30, 2016

This series of commits makes the following changes to the OpenStack Provider configuration:

  • Updates provider environment variables
  • Makes the password field sensitive
  • Adds Descriptions for all provider options
  • Cleans up the Provider documentation
  • Cleans up the EndpointType check

Fixes #8757
Fixes #8756
Fixes #7041

@stack72
Copy link
Contributor

stack72 commented Oct 30, 2016

@jtopjian is this backwards compatible? :)

@jtopjian
Copy link
Contributor Author

jtopjian commented Oct 30, 2016

@stack72 As far as the OpenStack-specific changes go, yes, totally backwards compatible. (Edit: the only change happening to the configuration structs is a alphabetical reorder for easier management)

With regard to the Terraform-specific changes (Description, Secret), do you know if those will trigger an issue with existing states?

@stack72
Copy link
Contributor

stack72 commented Oct 31, 2016

Nah these will be fine :) LGTM! good addition!

@stack72 stack72 merged commit 266b5ab into hashicorp:master Nov 1, 2016
gusmat pushed a commit to gusmat/terraform that referenced this pull request Dec 6, 2016
* provider/openstack: Adding Identity v3 compatible environment variables

* provider/openstack: Adding missing environment variables

* provider/openstack: line spacing for provider options

* provider/openstack: Making password sensitive

* provider/openstack: Adding descriptions to provider options

* provider/openstack: Clean up provider documentation

* provider/openstack: clean up EndpointType check
@jtopjian jtopjian deleted the openstack-provider-updates branch March 23, 2017 16:09
@ghost
Copy link

ghost commented Apr 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants